FEATURE: Preview for non site packages #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `packages` configuration can now be used to configure non-site packages for previewing in the styleguide.
When a prototyope of a non-site package is rendered Monocle will only load the Root.fusion of this specific package and the Monocle Root.fusion. Every other fusion including the default fusion has to be included explicitly. This mimics the behavior of the classic FusionView that is used for FusionRendering of Flow Controller Actions.
```YAML
Sitegeist:
Monocle:
packages:
#add a key to the package list without package specific configuration
'Vendor.Example': {}
```
mficzel
force-pushed
the
feature/previewForNonSitePackages
branch
from
c964170
to
692dd53
Compare
If a domain can be identified from the request monocle will use this to determine the initial sitePackage. If that does not work a newly added setting `defaultPackageKey` is used. If this setting was not set the key of the first site package or the first key in the `packages` configuration is used.
mficzel
force-pushed
the
feature/previewForNonSitePackages
branch
from
02b8a2d
to
7954576
Compare
|
I just noticed that the Neos dependency should also be removed in favor of a pure fusion dependency. Will add this to this branch soon. |
mficzel
force-pushed
the
feature/previewForNonSitePackages
branch
from
d75bea0
to
7448b3a
Compare
mficzel
force-pushed
the
feature/previewForNonSitePackages
branch
from
7448b3a
to
7954576
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
packagesconfiguration can now be used to configure non-site packages for previewing in the styleguide.When a prototyope of a non-site package is rendered Monocle will only load the Root.fusion of this specific package and the Monocle Root.fusion. Every other fusion including the default fusion has to be included explicitly. This mimics the behavior of the classic FusionView that is used for FusionRendering of Flow Controller Actions.
In addition a smarter and configurable way to determine the defaultPackageKey was added.
If a domain can be identified from the current request monocle will use this to determine the initial sitePackage.
If that does not work a newly added setting
defaultPackageKeyis used. If this setting is not set the key ofthe first site package or the first key in the
packagesconfiguration is used.Relates: #109
Resolves: #115